Skip to content

fix(agent): reject invalid output modes#50

Closed
JerryNee wants to merge 1 commit into
TestSprite:mainfrom
JerryNee:fix/agent-output-validation
Closed

fix(agent): reject invalid output modes#50
JerryNee wants to merge 1 commit into
TestSprite:mainfrom
JerryNee:fix/agent-output-validation

Conversation

@JerryNee

Copy link
Copy Markdown

Summary

  • validate testsprite agent ... --output <mode> against the supported json|text modes
  • return the existing local VALIDATION_ERROR shape instead of silently treating unsupported modes as text
  • add command-wiring coverage for agent list

Before

testsprite agent list --output yaml exited 0 and printed text output.

After

testsprite agent list --output yaml exits 5 with:

Error: Invalid request.
Flag `--output` is invalid: must be one of: json, text.

Verification

  • npm test -- src/commands/agent.test.ts
  • npm run lint
  • npm run typecheck
  • npm test
  • npm run build
  • node dist/index.js agent list --output yaml

@zeshi-du

Copy link
Copy Markdown
Contributor

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@zeshi-du, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 59 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 7f8d2074-391e-476b-808b-ec65b2133efc

📥 Commits

Reviewing files that changed from the base of the PR and between 15e95de and 2313711.

📒 Files selected for processing (2)
  • src/commands/agent.test.ts
  • src/commands/agent.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@zeshi-du

zeshi-du commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Thanks @JerryNee! 🙏

#14 introduces a shared resolveOutputMode() helper that applies this same --output validation across every command group in one place (including a few the per-command PRs didn't cover), so we're going with #14 as the single source of truth. Closing this as a duplicate in its favor.

Great catch on the gap — hope to see more PRs from you! 🚀

@zeshi-du zeshi-du closed this Jul 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants